This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
upgrade ringpop to latest #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address #225
There was a breaking ringpop change documented in https://github.com/uber/ringpop-go/blob/master/CHANGES.md:
Breaking change to the identity-option
Prior to ringpop v0.8.0 the address was used as the identity of a member. Starting with version v0.8.0, it's possible to configure a separate identity. As a result, the behaviour of the Identity and IdentityResolverFunc has been changed. The Identity option now configures the identity of a member and will return an error when it matches an ip:port; services that were using Identity or IdentityResolverFunc should now use the Address and AddressResolverFunc options. You could use the following gofmt snippets to easily refactor: