Skip to content
This repository has been archived by the owner on May 4, 2021. It is now read-only.

Add --target option to build command #331

Merged
merged 2 commits into from
May 3, 2020

Conversation

Rowern
Copy link
Contributor

@Rowern Rowern commented May 2, 2020

Maybe this Closes #262

But I saw #280 and don't really know why makisu should implement stages as tree ?

@yiranwang52
Copy link
Collaborator

yiranwang52 commented May 3, 2020

Tree is better for calculating cache IDs.
Currently stages inherit cache ID from last step of previous stage - which is not necessary if no files are copied between them.

Also in theory it's possible to execute some stages without "RUN" in parallel, or ignore those that not parent of target.

lib/builder/build_plan.go Outdated Show resolved Hide resolved
lib/builder/build_plan.go Outdated Show resolved Hide resolved
@yiranwang52 yiranwang52 merged commit c7788a1 into uber-archive:master May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multistage-build: add support for --target option
2 participants