Run lint on 1.12, remove pre-1.11 versions #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the Makefile to use ./... instead of a packages variable. Golint checks vendor when used with "./..." so pass in "." explicitly. This lint check was previously not even running (PKGS was undefined).
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 145 145
=====================================
Hits 145 145Continue to review full report at Codecov.
|
abhinav
reviewed
May 1, 2019
abhinav
approved these changes
May 1, 2019
prashantv
added a commit
that referenced
this pull request
Jul 9, 2019
Clean up the Makefile to use ./... instead of a packages variable. Golint checks vendor when used with "./..." so use `go list ./...`. This lint check was previously not even running (PKGS was undefined).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the Makefile to use ./... instead of a packages variable.
Golint checks vendor when used with "./..." so pass in "." explicitly.
This lint check was previously not even running (PKGS was undefined).