Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Concepts/Modules #971

Merged
merged 2 commits into from
Oct 13, 2022
Merged

docs: Add Concepts/Modules #971

merged 2 commits into from
Oct 13, 2022

Conversation

abhinav
Copy link
Collaborator

@abhinav abhinav commented Oct 13, 2022

Adds a Modules page under concepts
documenting fx.Modules.

Also adapts a subset of our internal "writing Fx modules"
for external consumption.

Adds a Modules page under concepts
documenting fx.Modules.

Also adapts a subset of our internal "writing Fx modules"
for external consumption.
@abhinav abhinav enabled auto-merge (squash) October 13, 2022 00:59
@abhinav abhinav requested review from r-hang and sywhang October 13, 2022 00:59
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #971 (2de6fc2) into master (1e38d57) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #971   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          38       38           
  Lines        1529     1529           
=======================================
  Hits         1508     1508           
  Misses         15       15           
  Partials        6        6           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@abhinav abhinav merged commit bd8f961 into master Oct 13, 2022
@abhinav abhinav deleted the docs-modules branch October 13, 2022 02:54
sywhang pushed a commit to sywhang/fx that referenced this pull request Oct 17, 2022
Adds a Modules page under concepts
documenting fx.Modules.

Also adapts a subset of our internal "writing Fx modules"
for external consumption.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants