Replace config.IsTestEnvironment with a configuration #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxincs
force-pushed
the
yuxincs/add-config-analyzer
branch
from
f065d95
to
ca3a1bb
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
1bb9133
to
717021a
Compare
yuxincs
force-pushed
the
yuxincs/add-config-analyzer
branch
from
ca3a1bb
to
cb84038
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
717021a
to
64b66ac
Compare
yuxincs
force-pushed
the
yuxincs/add-config-analyzer
branch
from
cb84038
to
cb1c20d
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
4 times, most recently
from
7456a3b
to
e92f4de
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
e92f4de
to
6990af9
Compare
lazaroclapp
reviewed
Aug 1, 2023
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
2 times, most recently
from
d6e0736
to
fe2b512
Compare
yuxincs
force-pushed
the
yuxincs/replace-is-test-environment
branch
from
fe2b512
to
4db2508
Compare
Right, it's probably better to test it. I have added a non-parallel test to the test suite to test this functionality (since it needs to change the global |
yuxincs
added a commit
that referenced
this pull request
Aug 4, 2023
This PR removes the hardcoded `nolint:nilaway` docstring check for both files and function declarations since it is no longer necessary: * files: we have implemented configuration analyzer in #9 which is able to take a list of strings to ignore the analysis of a file. * function declaration: it is mainly designed for two reasons: * performance: we were able to use it to manually skip the analysis of a particular function for performance reasons. However, we now have a timeout for analysis of any particular function, hence this is no longer required. * error suppression: most linter drivers, especially nogo, are now respecting `nolint`, so there is really no need to support it within the linter itself. Depends on #10
yuxincs
commented
Aug 4, 2023
Comment on lines
+221
to
+223
| // We specifically do not set this test to be parallel such that this test is run separately | ||
| // from the parallel tests. This makes it possible to set the pretty-print flag to true for | ||
| // testing and false for the other tests. |
There was a problem hiding this comment.
This is also documented here: https://pkg.go.dev/testing#T.Parallel
sonalmahajan15
pushed a commit
that referenced
this pull request
Aug 5, 2023
This PR replaces the global variable `config.IsTestEnvironment` with a user-configuration option `pretty-print` (default `true`). Then in our `TestMain` setup function we set this flag to be false for testing purposes. Depends on #9
sonalmahajan15
pushed a commit
that referenced
this pull request
Aug 5, 2023
This PR removes the hardcoded `nolint:nilaway` docstring check for both files and function declarations since it is no longer necessary: * files: we have implemented configuration analyzer in #9 which is able to take a list of strings to ignore the analysis of a file. * function declaration: it is mainly designed for two reasons: * performance: we were able to use it to manually skip the analysis of a particular function for performance reasons. However, we now have a timeout for analysis of any particular function, hence this is no longer required. * error suppression: most linter drivers, especially nogo, are now respecting `nolint`, so there is really no need to support it within the linter itself. Depends on #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the global variable
config.IsTestEnvironmentwith a user-configuration optionpretty-print(defaulttrue). Then in ourTestMainsetup function we set this flag to be false for testing purposes.Depends on #9