Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code for custom nilable types #283

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Conversation

yuxincs
Copy link
Contributor

@yuxincs yuxincs commented Sep 16, 2024

We do not really have custom nilable types for a really long time now, so it makes sense to remove the dead code.

If we ever want to add such custom nilable types again, we should consider adding a hook here via the hook framework (#278).

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.69%. Comparing base (ca8aade) to head (3fcfb27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   87.66%   87.69%   +0.03%     
==========================================
  Files          66       66              
  Lines        7943     7939       -4     
==========================================
- Hits         6963     6962       -1     
+ Misses        798      796       -2     
+ Partials      182      181       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 16, 2024

Golden Test

Note

✅ NilAway errors reported on standard libraries are identical.

3263 errors on base branch (main, ca8aade)
3263 errors on test branch (e4f8d66)

Copy link
Contributor

@sonalmahajan15 sonalmahajan15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the code cleanup

@yuxincs yuxincs merged commit ccdcbe7 into main Oct 5, 2024
9 checks passed
@yuxincs yuxincs deleted the yuxincs/remove-dead-code branch October 5, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants