Fix not working slack. #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 63 67 +4
=========================================
+ Hits 63 67 +4
Continue to review full report at Codecov.
|
As reported in #23 and #27 slack is currently broken in the atomic implementation. Both #23 and #27 propose valid solutions, and I actually arrived at #23 when trying to solve this independently, but I find #27 slightly more readable/understandable, so going with that. Also, #23 seems to expose another bug in andres-erbsen/clock, with sleeping with negative time, so we should probably consider switching to benbjohnson/clock - maybe in a follow up.
|
ping @cinchurge ;) Note that #56 is landed now, so we have two implementations to compare against - effectively two tests;) |
|
@abhinav, could you take a look? The tests are passing, this is okay even if the atomic implementation still needs more testing & decision. All this is just so that we don't have obvious bugs & missing features. Once this lands we'll be able to fix a few other slack issues (allow people to configure slack) and maybe release a new minor version (see #55). |
As reported in #23 and #27 slack is currently broken in the atomic
implementation.
Both #23 and #27 propose valid solutions, and I actually arrived
at #23 when trying to solve this independently, but I find #27
slightly more readable/understandable, so going with that.