Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge bucketed subscope to V4 release #191

Merged
merged 4 commits into from
Dec 6, 2022
Merged

Conversation

brawndou
Copy link
Collaborator

@brawndou brawndou commented Dec 6, 2022

Changes:

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #191 (0ada30f) into master (92a308b) will increase coverage by 0.09%.
The diff coverage is 94.33%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   47.36%   47.46%   +0.09%     
==========================================
  Files          64       64              
  Lines        5937     5948      +11     
==========================================
+ Hits         2812     2823      +11     
  Misses       2685     2685              
  Partials      440      440              
Impacted Files Coverage Δ
scope_registry.go 95.45% <94.23%> (+0.64%) ⬆️
scope.go 95.01% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brawndou brawndou marked this pull request as ready for review December 6, 2022 00:24
@brawndou brawndou merged commit 7f86cc4 into uber-go:master Dec 6, 2022
@brawndou brawndou mentioned this pull request Dec 6, 2022
brawndou added a commit to brawndou/tally that referenced this pull request Dec 8, 2022
* increment version

* Use bucketed subscope (uber-go#184)

* remove unused function

Co-authored-by: Cristian Velazquez <cdvr1993@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants