TestScope: don't prune from registry when closed #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devastating
approved these changes
Jun 10, 2023
brawndou
pushed a commit
to brawndou/tally
that referenced
this pull request
Jan 24, 2024
brawndou
pushed a commit
to brawndou/tally
that referenced
this pull request
Jan 24, 2024
brawndou
added a commit
that referenced
this pull request
Jan 25, 2024
* [bug] Ensure that parent scopes do not return closed subscopes (#221) * TestScope: don't prune from registry when closed (#222) * TestScope: don't prune from registry when closed (#222) * lint fix * move comment * update go.mod and go.sum * add license header --------- Co-authored-by: Matt Way <mway@users.noreply.github.com>
brawndou
added a commit
to brawndou/tally
that referenced
this pull request
Jan 26, 2024
* [bug] Ensure that parent scopes do not return closed subscopes (uber-go#221) * TestScope: don't prune from registry when closed (uber-go#222) * TestScope: don't prune from registry when closed (uber-go#222) * lint fix * move comment * update go.mod and go.sum * add license header --------- Co-authored-by: Matt Way <mway@users.noreply.github.com>
brawndou
added a commit
that referenced
this pull request
Jan 26, 2024
* Revise internal cardinality metrics (#241) * Backport #221 and #222 to master branch (#243) * [bug] Ensure that parent scopes do not return closed subscopes (#221) * TestScope: don't prune from registry when closed (#222) --------- Co-authored-by: Matt Way <mway@users.noreply.github.com> --------- Co-authored-by: Matt Way <mway@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #221 we ensure that closed scopes aren't returned by the registry.
However, because of how test scopes work, we need to keep them around in order to ensure that snapshots report the expected value, as those metrics are not accumulated outside of the scopes that are being closed.