Skip to content

Commit

Permalink
Unexport ObservedLogs.Add
Browse files Browse the repository at this point in the history
  • Loading branch information
Akshay Shah committed Mar 14, 2017
1 parent 5e0a0db commit c6e59b3
Showing 1 changed file with 7 additions and 8 deletions.
15 changes: 7 additions & 8 deletions zaptest/observer/observer.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,6 @@ type ObservedLogs struct {
logs []LoggedEntry
}

// Add appends a new observed log to the collection.
func (o *ObservedLogs) Add(log LoggedEntry) {
o.mu.Lock()
o.logs = append(o.logs, log)
o.mu.Unlock()
}

// Len returns the number of items in the collection.
func (o *ObservedLogs) Len() int {
o.mu.RLock()
Expand Down Expand Up @@ -87,6 +80,12 @@ func (o *ObservedLogs) AllUntimed() []LoggedEntry {
return ret
}

func (o *ObservedLogs) add(log LoggedEntry) {
o.mu.Lock()
o.logs = append(o.logs, log)
o.mu.Unlock()
}

// New creates a new Core that buffers logs in memory (without any encoding).
// It's particularly useful in tests.
func New(enab zapcore.LevelEnabler) (zapcore.Core, *ObservedLogs) {
Expand Down Expand Up @@ -122,7 +121,7 @@ func (co *contextObserver) Write(ent zapcore.Entry, fields []zapcore.Field) erro
all := make([]zapcore.Field, 0, len(fields)+len(co.context))
all = append(all, co.context...)
all = append(all, fields...)
co.logs.Add(LoggedEntry{ent, all})
co.logs.add(LoggedEntry{ent, all})
return nil
}

Expand Down

0 comments on commit c6e59b3

Please sign in to comment.