added missing modules download #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1044 +/- ##
=======================================
Coverage 98.11% 98.11%
=======================================
Files 48 48
Lines 2071 2071
=======================================
Hits 2032 2032
Misses 30 30
Partials 9 9 Continue to review full report at Codecov.
|
abhinav
reviewed
Jan 4, 2022
.github/workflows/go.yml
Outdated
Comment on lines
41
to
43
| cd tools && go mod download && cd - | ||
| cd benchmarks && go mod download && cd - | ||
| cd zapgrpc/internal/test && go mod download && cd - |
There was a problem hiding this comment.
We can use subshells to avoid cding back.
Suggested change
| cd tools && go mod download && cd - | |
| cd benchmarks && go mod download && cd - | |
| cd zapgrpc/internal/test && go mod download && cd - | |
| (cd tools && go mod download) | |
| (cd benchmarks && go mod download) | |
| (cd zapgrpc/internal/test && go mod download) |
abhinav
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed two more modules in PR-1043
Now the action builds skipping the all downloads from those modules.