internal: Add and use a generic pool instead of using sync.Pool directly #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1262 +/- ##
==========================================
- Coverage 98.23% 98.08% -0.15%
==========================================
Files 49 50 +1
Lines 3231 3240 +9
==========================================
+ Hits 3174 3178 +4
- Misses 49 53 +4
- Partials 8 9 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mway
force-pushed
the
mway/generic-pool
branch
2 times, most recently
from
174bed1
to
cb7832f
Compare
abhinav
approved these changes
Mar 20, 2023
abhinav
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces discretely-typed
sync.Poolwrappers with a generic wrapper so that pools have a strongly-typed API rather than doing callsite type assertions.