[Feature] zapgrpc.Logger implements Experimental DepthLoggerV2 #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
forsaken628
changed the title
forsaken628
changed the title
|
@forsaken628 thanks for the submission, do you have any additional info on why this is needed on Zap's side? The issue you created doesn't have most of its fields filled out properly. |
|
The current zapgrpc package is poorly maintained and outdated. This PR just fills in the parts that this package should have. Or zapgrpc should be marked as deprecated. |
|
Any updates on this? It definitely looks like zapgrpc package is outdated compared to |
Signed-off-by: coldWater <forsaken628@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1267
https://github.com/grpc/grpc-go/blob/5e587344eef8aaa06ebf76ee1997013b3a8fbed0/grpclog/loggerv2.go#L240
and fix verbosity
grpc-ecosystem/go-grpc-middleware#452