Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: Enable errcheck, fix failures #1345

Merged
merged 4 commits into from
Sep 6, 2023

test(CheckedEntry): Reuse detection

b86843b
Select commit
Loading
Failed to load commit list.
Merged

lint: Enable errcheck, fix failures #1345

test(CheckedEntry): Reuse detection
b86843b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 2, 2023 in 1s

98.03% (target 95.00%)

View this Pull Request on Codecov

98.03% (target 95.00%)

Details

Codecov Report

Merging #1345 (b86843b) into master (b900128) will increase coverage by 0.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
+ Coverage   97.58%   98.03%   +0.44%     
==========================================
  Files          52       52              
  Lines        3392     3403      +11     
==========================================
+ Hits         3310     3336      +26     
+ Misses         71       58      -13     
+ Partials       11        9       -2     
Files Changed Coverage Δ
error.go 100.00% <100.00%> (ø)
http_handler.go 100.00% <100.00%> (ø)
logger.go 96.55% <100.00%> (ø)
sink.go 100.00% <100.00%> (ø)
writer.go 100.00% <100.00%> (ø)
zapcore/core.go 93.61% <100.00%> (ø)
zapcore/entry.go 98.33% <100.00%> (+8.33%) ⬆️
zapcore/error.go 86.27% <100.00%> (+0.85%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more