zapslog: Bump zap from v1.24.0 to v1.26.0 #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arukiidou
commented
Jan 28, 2024
arukiidou
commented
- Bump zap from v1.24.0 to v1.26.0
- v1.24.0...v1.26.0
Signed-off-by: junya koyama <arukiidou@yahoo.co.jp>
abhinav
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
I'm not opposed to this, but @arukiidou is there a reason you want to do this?
IIRC, zapslog doesn't use any features that are present only in 1.26.
There's nothing stopping a user from using zapslog + Zap 1.26 even without this change.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1404 +/- ##
=======================================
Coverage 98.28% 98.28%
=======================================
Files 53 53
Lines 3495 3495
=======================================
Hits 3435 3435
Misses 50 50
Partials 10 10 ☔ View full report in Codecov by Sentry. |
|
@abhinav It has not yet been decided that this is necessary, but there are advantages to making the change atomically |
|
Makes sense. Thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.