Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add Caller/Callers fields #183

Closed
wants to merge 5 commits into from
Closed

WIP: Add Caller/Callers fields #183

wants to merge 5 commits into from

Conversation

jcorbin
Copy link
Contributor

@jcorbin jcorbin commented Nov 16, 2016

This PR is essentially a proposal-as-prototype-code, rather than than proposal-as-issue; how about:

  • replacing zap.Stack with zap.Callers
  • simplifying the zap.AddCaller hook to just add a zap.Caller field, rather than mutate msg...
  • ...oh and also let the user pass a skip offset to zap.AddCaller so that it can get it right under logger wrappers

Other questions include:

  • what if we added proper array support, rather than the hacked object? (see also JSON Array support #136)
  • maybe we should have explicit PC(s) marshaling support in the the KeyValue interface itself...
  • ...this would let the text encoder recover a more human friendly stacktrace-esque form
  • ...maybe the Error field should also always (modulo an Option?) add a callers field?

@CLAassistant
Copy link

CLAassistant commented Dec 2, 2016

CLA assistant check
All committers have signed the CLA.

@jcorbin
Copy link
Contributor Author

jcorbin commented Dec 23, 2016

Superceded by #201, will open an issue to discuss what missing functionality we want to support going forward.

@jcorbin jcorbin closed this Dec 23, 2016
@jcorbin jcorbin deleted the callers branch December 23, 2016 01:05
@jcorbin jcorbin mentioned this pull request Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants