Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export the _callerSkip to make AddCaller user can change the skip manually #215

Closed
wants to merge 1 commit into from
Closed

Conversation

arthurkiller
Copy link
Contributor

export the _callerSkip for user to change the skip manually

@mention-bot
Copy link

@arthurkiller, thanks for your PR! By analyzing the history of the files in this pull request, we identified @akshayjshah and @jcorbin to be potential reviewers.

@arthurkiller
Copy link
Contributor Author

I don't understand why CI failed in go1.7 May be the CI trigger need to review

@arthurkiller
Copy link
Contributor Author

arthurkiller commented Dec 21, 2016

On my Mac , make lint can perform well with go 1.7

@arthurkiller arthurkiller changed the title export the _callerSkip to make user can change the skip manually export the _callerSkip to make AddCaller user can change the skip manually Dec 21, 2016
@akshayjshah
Copy link
Contributor

Hi @arthurkiller - for some context on this issue, see #40. You're right that the AddCaller hook isn't working well at the moment; however, the best fix isn't to export it and make callers configure it. Instead of being a global variable, it needs to be a per-logger field - a sampled logger and a plain logger need to skip different numbers of fields, for example.

@jcorbin is working on this in his dev branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants