Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support construction of zap-backed log.Loggers #353

Merged
merged 2 commits into from
Mar 7, 2017
Merged

Conversation

akshayjshah
Copy link
Contributor

@akshayjshah akshayjshah commented Mar 7, 2017

In addition to letting users redirect the output of the standard library's package-global log functions, we should also support wrapping a zap logger in a log.Logger.

This is the same PR as #344, which I somehow closed by mistake :/

Thanks to @flisky for the initial code and the suggestion.

flisky and others added 2 commits March 7, 2017 08:35
Sometimes other library requires a log.Logger instance,
but the builtin log doesn't expose the std variable.
@mention-bot
Copy link

@akshayjshah, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peter-edge and @skipor to be potential reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants