Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "errors: Support multierr and pkg/errors (#460)" #464

Closed
wants to merge 1 commit into from

Conversation

akshayjshah
Copy link
Contributor

This reverts commit acea907.

As outlined in a post-merge discussion on #460, let's reconsider this approach.

@akshayjshah
Copy link
Contributor Author

Argh, CLI fail - didn't intend to open this.

@akshayjshah akshayjshah closed this Jul 3, 2017
@codecov
Copy link

codecov bot commented Jul 3, 2017

Codecov Report

Merging #464 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   97.32%   97.28%   -0.05%     
==========================================
  Files          36       35       -1     
  Lines        1907     1876      -31     
==========================================
- Hits         1856     1825      -31     
  Misses         42       42              
  Partials        9        9
Impacted Files Coverage Δ
error.go 100% <ø> (ø) ⬆️
zapcore/field.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acea907...3973fb1. Read the comment docs.

@akshayjshah akshayjshah deleted the ajs-errs branch July 22, 2017 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant