Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip zap stack frames in stacktrace output #491

Merged
merged 2 commits into from
Aug 17, 2017
Merged

Skip zap stack frames in stacktrace output #491

merged 2 commits into from
Aug 17, 2017

Conversation

prashantv
Copy link
Collaborator

Currently, zap only filters out runtime stackframes, which leaves a lot
of noise from zap (Error, log, check, etc). This modifies the stacktrace
to filter out all zap frames at the beginning of the stack. It will not
filter out zap stacks in between non-zap frames.

Fixes #488.

Currently, zap only filters out runtime stackframes, which leaves a lot
of noise from zap (Error, log, check, etc). This modifies the stacktrace
to filter out all zap frames at the beginning of the stack. It will not
filter out zap stacks in between non-zap frames.

Fixes #488.
@codecov
Copy link

codecov bot commented Aug 16, 2017

Codecov Report

Merging #491 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage    96.9%   96.93%   +0.03%     
==========================================
  Files          36       36              
  Lines        2197     2219      +22     
==========================================
+ Hits         2129     2151      +22     
  Misses         59       59              
  Partials        9        9
Impacted Files Coverage Δ
stacktrace.go 90.47% <100%> (+5.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e68420e...e5d95e3. Read the comment docs.

Copy link
Contributor

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants