Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix putting nil to fmt.Stringer interface #674

Closed
wants to merge 1 commit into from
Closed

Conversation

fpuc
Copy link

@fpuc fpuc commented Jan 30, 2019

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #674 into master will decrease coverage by 0.09%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #674     +/-   ##
=========================================
- Coverage   97.38%   97.29%   -0.1%     
=========================================
  Files          40       40             
  Lines        2102     2105      +3     
=========================================
+ Hits         2047     2048      +1     
- Misses         47       48      +1     
- Partials        8        9      +1
Impacted Files Coverage Δ
zapcore/field.go 97.5% <50%> (-2.5%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e3b47...b4d67df. Read the comment docs.

@fpuc
Copy link
Author

fpuc commented Jan 30, 2019

closing in favour of #675

@fpuc fpuc closed this Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants