Add Go 1.12 for Travis #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
=======================================
Coverage 97.43% 97.43%
=======================================
Files 40 40
Lines 2109 2109
=======================================
Hits 2055 2055
Misses 46 46
Partials 8 8Continue to review full report at Codecov.
|
Note: We're keeping 1.10 and using it for linting as the lint Makefile rules have to change for 1.12 support (can't use go tool vet).
abhinav
approved these changes
Apr 29, 2019
Co-Authored-By: prashantv <github@prashantv.com>
lixingwang
added a commit
to lixingwang/zap
that referenced
this pull request
May 10, 2019
* master: README: Switch to travis-ci.com for badge (uber-go#709) Fix changelog links for 675 Prep for 1.10.0 release, update CHANGELOG (uber-go#705) Add Go 1.12 for Travis (uber-go#707) Fix call depth of standard logger in go1.12 (uber-go#706) Fix inconsistency between MapObjectEncoder's AddByteString and AppendByteString (uber-go#657) Disable HTMLEscape in reflect JSON encoder (uber-go#704)
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Makefile rules have to change for 1.12 support (can't use go tool vet). Drops 1.10 as we only support current and previous release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile rules have to change for 1.12 support (can't use go tool vet).
Drops 1.10 as we only support current and previous release.