-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RFC3339, RFC3339Nano and update docs to include 'nano' #736
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @uhthomas
Can you please include unit tests in encoder_test.go
@prashantv Absolutely! I've added some unit tests :) |
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 97.43% 97.44% +<.01%
==========================================
Files 40 40
Lines 2109 2117 +8
==========================================
+ Hits 2055 2063 +8
Misses 46 46
Partials 8 8
Continue to review full report at Codecov.
|
Awesome, thanks for the approval @prashantv! What's required to get this merged? |
Nothing else needed, I'll merge now :) |
I was going to open an issue but #659 is already open.
Go's time package suggests that 'RFC3339 should be preferred for new protocols' so it would be great to have RFC3339 as a standard time format in zap.