Fix handling of Time values out of UnixNano range #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #737, #803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
Codecov Report
@@ Coverage Diff @@
## master #804 +/- ##
=======================================
Coverage 98.31% 98.31%
=======================================
Files 43 43
Lines 2311 2315 +4
=======================================
+ Hits 2272 2276 +4
Misses 32 32
Partials 7 7
Continue to review full report at Codecov.
|
abhinav
reviewed
Mar 24, 2020
prashantv
changed the title
abhinav
reviewed
Mar 25, 2020
zapcore/field_test.go
Outdated
| @@ -164,6 +165,10 @@ func TestFields(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestEquals(t *testing.T) { | |||
| timeOutOfRange := time.Unix(0, math.MaxInt64).Add(time.Nanosecond) | |||
| timeOutOfRangeNano := time.Unix(0, timeOutOfRange.UnixNano()) | |||
There was a problem hiding this comment.
We should try out of range in both directions.
Co-Authored-By: Abhinav Gupta <abg@uber.com>
abhinav
approved these changes
Mar 26, 2020
Co-Authored-By: Abhinav Gupta <abg@uber.com>
abhinav
approved these changes
Mar 26, 2020
uvfive
pushed a commit
to bxsmart/zap
that referenced
this pull request
May 21, 2020
Fixes uber-go#737, uber-go#803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
cgxxv
pushed a commit
to cgxxv/zap
that referenced
this pull request
Mar 25, 2022
Fixes uber-go#737, uber-go#803. Time values are encoded by storing the UnixNano representation, but this fails when the value of UnixNano is out of int64 range, see docs: https://golang.org/pkg/time/#Time.UnixNano > The result is undefined if the Unix time in nanoseconds cannot be represented by an int64 (a date before the year 1678 or after 2262) Fix this by storing values outside of UnixNano range as-is rather than using UnixNano with a new Field type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737, #803.
Time values are encoded by storing the UnixNano representation, but this
fails when the value of UnixNano is out of int64 range, see docs:
https://golang.org/pkg/time/#Time.UnixNano
Fix this by storing values outside of UnixNano range as-is rather
than using UnixNano with a new Field type.