Code

core/sampler: Support decision hook#813

Code

Merged

abhinav merged 17 commits intouber-go:masteruber-go/zap:masterfrom shirchen:shirchen/T5056227shirchen/zap:shirchen/T5056227Copy head branch name to clipboardApr 21, 2020

+227-18

Commits

Commits on Apr 4, 2020

• Fix unit tests and a sample sampler start.

  shirchen

  committed
  14b1350

  Copy full SHA for 14b1350

• outlines of a zap sampler option

  shirchen

  committed
  c59b269

  Copy full SHA for c59b269

• Deprecate NewSampler and add a default a nop SamplerHook.

  shirchen

  committed
  e268359

  Copy full SHA for e268359

• Nop hook to NewSampler.

  shirchen

  committed
  cefe15e

  Copy full SHA for cefe15e

• Add a default nop hook everywhere.

  shirchen

  committed
  1f5cf2c

  Copy full SHA for 1f5cf2c

• Add more docs

  shirchen

  committed
  44fe037

  Copy full SHA for 44fe037

• Fix lint and switch back to using NewSampler in a test for cc.

  shirchen

  committed
  25478e6

  Copy full SHA for 25478e6

• Fix comment and add deprecated constructor in a different place for cc.

  shirchen

  committed
  5cc987e

  Copy full SHA for 5cc987e

Commits on Apr 7, 2020

• Simplify default constructor, add a sample event, do not return error

  Show description for fd20684
  shirchen

  committed
  fd20684

  Copy full SHA for fd20684

• add sampler benchmark for hook.

  shirchen

  committed
  4ae250b

  Copy full SHA for 4ae250b

Commits on Apr 8, 2020

• lint

  shirchen

  committed
  d48791a

  Copy full SHA for d48791a

Commits on Apr 9, 2020

• Address feedback.

  shirchen

  committed
  3c00734

  Copy full SHA for 3c00734

• lint and fix comments

  shirchen

  committed
  0bc5a78

  Copy full SHA for 0bc5a78

Commits on Apr 14, 2020

• Name return values, clarify count hook accounting.

  shirchen

  committed
  8b91fbb

  Copy full SHA for 8b91fbb

Commits on Apr 21, 2020

• Check SamplingDecision as a bit field and expand to 32 bits.

  shirchen

  committed
  09045e2

  Copy full SHA for 09045e2

• lint

  shirchen

  committed
  6d960ec

  Copy full SHA for 6d960ec

• delete confusing assert and more docs

  shirchen

  committed
  ae3e230

  Copy full SHA for ae3e230