Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to customize Fatal behaviour for better testability #861

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Add options to customize Fatal behaviour for better testability #861

merged 5 commits into from
Sep 1, 2020

Commits on Sep 1, 2020

  1. Add options to customize Fatal behaviour for better testability 

    Fixes #846.

There's currently no easy way to test Fatal from outside of zap, as it
triggers an os.Exit(1). Add options to customize the behaviour (allowing
for panic, or Goexit), which can be used with `recover()` in tests.
    @prashantv
    prashantv committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    63c7223 View commit details
    Browse the repository at this point in the history

  2. Remove trailing period from fragment comment 

    Co-authored-by: Abhinav Gupta <abg@uber.com>
    @prashantv @abhinav
    prashantv and abhinav authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    10cad3b View commit details
    Browse the repository at this point in the history

  3. Check for noop specifically 

    Co-authored-by: Abhinav Gupta <abg@uber.com>
    @prashantv @abhinav
    prashantv and abhinav authored Sep 1, 2020
    Configuration menu
    Copy the full SHA
    72a03b5 View commit details
    Browse the repository at this point in the history

  4. Move WriteThenGoexit to before WriteThenPanic

    @prashantv
    prashantv committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    ba96f32 View commit details
    Browse the repository at this point in the history

  5. Add comment for Noop check

    @prashantv
    prashantv committed Sep 1, 2020
    Configuration menu
    Copy the full SHA
    5de1194 View commit details
    Browse the repository at this point in the history