Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trace level #933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Trace level #933

wants to merge 1 commit into from

Conversation

samsondav
Copy link

See: #680

@CLAassistant
Copy link

CLAassistant commented Apr 7, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.28%. Comparing base (c23abee) to head (8df91e1).
Report is 234 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
- Coverage   98.54%   98.28%   -0.27%     
==========================================
  Files          44       44              
  Lines        3724     1987    -1737     
==========================================
- Hits         3670     1953    -1717     
+ Misses         40       27      -13     
+ Partials       14        7       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nivBlox
Copy link

nivBlox commented Apr 12, 2021

Hey guys, any update for this pr?
We are looking for a way to add trace level too

Thanks!

@prashantv
Copy link
Collaborator

Please take a look at previous concerns raised about adding a trace level to zap:
#749 (comment)

@samsondav
Copy link
Author

@prashantv what about inclusion in a new major version?

@prashantv
Copy link
Collaborator

We're tracking wishlist for new features for a 2.0 in #388

However, there's no concrete timelines for a 2.0, and we're trying to avoid the disruption caused by a new major version.

@samsondav samsondav mentioned this pull request May 3, 2021
@chiragtaunk13
Copy link

Thanks for making this change.
We are also looking for Trace Level support.

What is the plan on this merge?

Tried import from @samsondav 's repo, but facing go mod problem:

go: downloading github.com/samsondav/zap v1.16.0
go: github.com/samsondav/zap upgrade => v1.16.0
go get: github.com/samsondav/zap@v1.16.0: parsing go.mod:
        module declares its path as: go.uber.org/zap
                but was required as: github.com/samsondav/zap

@andig
Copy link

andig commented May 24, 2021

@chiragtaunk13 use go.mod replace directive for that purpose. Note its only recommended as temporary workaround.

@jamelt
Copy link

jamelt commented Jul 22, 2021

im really curious how you guys handle not having trace support? are you guys just liberal in what you all log?

This was referenced Nov 5, 2021
@franklinkim
Copy link

Hi, any updates on this one or futures plans regarding the wishlist for new features for a 2.0 in #388?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

9 participants