-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trace level #933
base: master
Are you sure you want to change the base?
Add Trace level #933
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 98.54% 98.28% -0.27%
==========================================
Files 44 44
Lines 3724 1987 -1737
==========================================
- Hits 3670 1953 -1717
+ Misses 40 27 -13
+ Partials 14 7 -7 ☔ View full report in Codecov by Sentry. |
Hey guys, any update for this pr? Thanks! |
Please take a look at previous concerns raised about adding a trace level to zap: |
@prashantv what about inclusion in a new major version? |
We're tracking wishlist for new features for a 2.0 in #388 However, there's no concrete timelines for a 2.0, and we're trying to avoid the disruption caused by a new major version. |
Thanks for making this change. What is the plan on this merge? Tried import from @samsondav 's repo, but facing go mod problem:
|
@chiragtaunk13 use go.mod replace directive for that purpose. Note its only recommended as temporary workaround. |
im really curious how you guys handle not having trace support? are you guys just liberal in what you all log? |
Hi, any updates on this one or futures plans regarding the wishlist for new features for a 2.0 in #388? |
See: #680