NopLogger: Fix nil Clock panic and release #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #897, we added a `zap.Clock` option to control the source of time but neglected to set this field on the logger constructed by `zap.NewNop`. This has the effect of panicking the Nop logger with a nil dereference. Fix the nil dereference and add checks for the behavior of the Nop logger. Verified that these are the only instantiations of `Logger` in this package: ``` $ rg '\bLogger\{' *.go logger_test.go 67: for _, logger := range []*Logger{grandparent, parent, child} { logger.go 71: log := &Logger{ 86: return &Logger{ ``` Refs GO-684
Codecov Report
@@ Coverage Diff @@
## master #974 +/- ##
=======================================
Coverage 98.19% 98.20%
=======================================
Files 46 46
Lines 2055 2056 +1
=======================================
+ Hits 2018 2019 +1
Misses 29 29
Partials 8 8
Continue to review full report at Codecov.
|
This tags a patch release of the breakage introduced in 1.18.0.
abhinav
changed the title
prashantv
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #897, we added a
zap.Clockoption to control the source of timebut neglected to set this field on the logger constructed by
zap.NewNop. This has the effect of panicking the Nop logger with a nildereference.
Fix the nil dereference and add checks for the behavior of the Nop
logger, and tag a new patch release with the fix.
Verified that these are the only instantiations of
Loggerin thispackage:
Refs GO-684