Null if check and failing function to taken in account

[sdeleuze]

Code with if (obj == null) and a failing function seems not taken in account properly.

Object obj = model.get(modelName);
if (obj == null) {
	fail("Model attribute with name '" + modelName + "' is null");
}
assertTrue(obj.getClass().getName(), expectedType.isAssignableFrom(obj.getClass()));

With

@Contract("_ -> fail")
public static void fail(String message) {
	throw new AssertionError(message);
}

Generates this irrelevant error:

[NullAway] dereferenced expression obj is @Nullable
                                obj.getClass().getName(), expectedType.isAssignableFrom(obj.getClass()));

[msridhar]

Hi @sdeleuze thanks for the report; we can add support for this case. As a workaround, if you have a fail method that takes both a boolean and a String, that should already be supported. See this new test:

https://github.com/uber/NullAway/pull/945/files

Maybe that is not an option here for performance reasons?

[sdeleuze]

Thanks, the main reason why I don't have a workaround here is that fail(String message) is part of Spring public API and I can't change it.