Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use type arguments of generic methods to check for generic type parameter's nullability #1067

Closed
wants to merge 4 commits into from

Conversation

haewiful
Copy link
Contributor

@haewiful haewiful commented Nov 5, 2024

  • I have made NullAway to check generic type parameter's nullability using the type arguments passed at the call site (generic methods).

  • The relevant unit test is void genericMethodAndVoidType() in the jspecify/GenericMethodTests.java file.

@haewiful haewiful marked this pull request as ready for review November 5, 2024 03:15
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (17fc1ba) to head (e1611dd).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1067      +/-   ##
============================================
+ Coverage     87.66%   87.68%   +0.02%     
- Complexity     2222     2225       +3     
============================================
  Files            86       86              
  Lines          7271     7284      +13     
  Branches       1436     1438       +2     
============================================
+ Hits           6374     6387      +13     
  Misses          456      456              
  Partials        441      441              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haewiful haewiful closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants