Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest correct fix when array component of non-nullable array is made null. #1087

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

avenger2597
Copy link
Contributor

This PR changes the ErrorDescription to pass the arraySymbol as the 'nonNullTarget' for a suggested fix in the scenario when the content of an array with component non-nullable is made null.

I have made the above change and tested it in the unit case errorSerializationTestArrayComponentNull() in the SerializationTest.java class.

@CLAassistant
Copy link

CLAassistant commented Dec 10, 2024

CLA assistant check
All committers have signed the CLA.

@msridhar msridhar self-requested a review December 12, 2024 01:38
Copy link
Collaborator

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.87%. Comparing base (6c498b6) to head (d8cd99e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1087      +/-   ##
============================================
- Coverage     87.87%   87.87%   -0.01%     
  Complexity     2217     2217              
============================================
  Files            85       85              
  Lines          7194     7193       -1     
  Branches       1427     1427              
============================================
- Hits           6322     6321       -1     
  Misses          438      438              
  Partials        434      434              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msridhar msridhar merged commit 1fc39b3 into uber:master Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants