Fix crash with annotation on enum #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1097 +/- ##
============================================
+ Coverage 88.09% 88.11% +0.01%
- Complexity 2204 2205 +1
============================================
Files 84 84
Lines 7175 7175
Branches 1423 1423
============================================
+ Hits 6321 6322 +1
+ Misses 431 430 -1
Partials 423 423 ☔ View full report in Codecov by Sentry. |
stefanheule
approved these changes
Dec 17, 2024
| @@ -367,8 +367,10 @@ private static boolean targetTypeMatches(Symbol sym, TypeAnnotationPosition posi | |||
| return false; | |||
| } | |||
| case CLASS: | |||
| // There are no type annotations on the top-level type of the class being declared, only | |||
| // on other types in the signature (e.g. `class Foo extends Bar<@A Baz> {}`). | |||
| // treated like a class | |||
There was a problem hiding this comment.
Consider moving the comment on the same line as case ENUM and/or changing the comment to enums are treated like a class. It's slightly confusing right now because it appears in the block after case CLASS (though after some staring I understand it's meant to be a comment for the case ENUM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1093
We just missed a case.