Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSpecify: preserve explicit nullability annotations on type variables when performing substitutions #1143

Merged
merged 36 commits into from
Feb 13, 2025

Merge branch 'master' into issue-1091

9674e64
Select commit
Loading
Failed to load commit list.
Merged

JSpecify: preserve explicit nullability annotations on type variables when performing substitutions #1143

Merge branch 'master' into issue-1091
9674e64
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 10, 2025 in 0s

88.12% (-0.13%) compared to a1df1c4

View this Pull Request on Codecov

88.12% (-0.13%) compared to a1df1c4

Details

Codecov Report

Attention: Patch coverage is 77.77778% with 40 lines in your changes missing coverage. Please review.

Project coverage is 88.12%. Comparing base (a1df1c4) to head (9674e64).

Files with missing lines Patch % Lines
...om/uber/nullaway/generics/TypeMetadataBuilder.java 70.78% 26 Missing ⚠️
.../uber/nullaway/generics/TypeSubstitutionUtils.java 82.05% 5 Missing and 9 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1143      +/-   ##
============================================
- Coverage     88.25%   88.12%   -0.13%     
- Complexity     2264     2265       +1     
============================================
  Files            85       86       +1     
  Lines          7320     7427     +107     
  Branches       1463     1483      +20     
============================================
+ Hits           6460     6545      +85     
- Misses          432      445      +13     
- Partials        428      437       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov