Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue when building on JDK 17 but running on JDK 8 #779

Merged
merged 5 commits into from
Jul 15, 2023

Conversation

msridhar
Copy link
Collaborator

Error Prone ran into a similar issue in google/error-prone#3895. We re-use the same fix, and also add a CI job to test this case. We could avoid this problem by only building releases on JDK 11, but might as well fix to avoid that requirement.

@coveralls
Copy link

coveralls commented Jul 14, 2023

Pull Request Test Coverage Report for Build #1136

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.05%) to 92.759%

Files with Coverage Reduction New Missed Lines %
../nullaway/src/main/java/com/uber/nullaway/handlers/GrpcHandler.java 1 98.25%
../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java 3 95.26%
../nullaway/src/main/java/com/uber/nullaway/NullabilityUtil.java 5 93.64%
../nullaway/src/main/java/com/uber/nullaway/handlers/ApacheThriftIsSetHandler.java 6 82.76%
Totals Coverage Status
Change from base Build #1134: -0.05%
Covered Lines: 5611
Relevant Lines: 6049

💛 - Coveralls

@msridhar msridhar enabled auto-merge (squash) July 14, 2023 23:17
@msridhar msridhar disabled auto-merge July 14, 2023 23:17
Copy link
Contributor

@ketkarameya ketkarameya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@msridhar msridhar merged commit 61abe56 into master Jul 15, 2023
@msridhar msridhar deleted the build-on-jdk17-run-on-jdk8-fix branch July 15, 2023 22:06
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 18, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
msridhar added a commit to msridhar/NullAway that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants