Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suspend functions callable inside test(worker) { } #624

Merged
merged 1 commit into from
Nov 9, 2023
+3 −1
Merged

Make suspend functions callable inside test(worker) { } #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions android/libraries/rib-base/src/test/kotlin/com/uber/rib/core/RibCoroutineWorkerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,8 @@ class RibCoroutineWorkerTest {
assertThat(worker.innerCoroutineCompleted).isFalse()
assertThat(worker.onStopRan).isFalse()
test(worker) {
// Quick check that suspend functions can be called inside this block
delay(0)
// Assert onStart and inner coroutine started but have not finished (it has delays)
assertThat(it.onStartStarted).isTrue()
assertThat(it.innerCoroutineStarted).isTrue()
Expand Down
2 changes: 1 addition & 1 deletion android/libraries/rib-test/src/main/kotlin/com/uber/rib/core/TestRibCoroutineWorker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import kotlinx.coroutines.test.runCurrent
@OptIn(ExperimentalCoroutinesApi::class)
public inline fun <T : RibCoroutineWorker> TestScope.test(
worker: T,
crossinline testBody: TestScope.(T) -> Unit,
testBody: TestScope.(T) -> Unit,
) {
val dispatcher = StandardTestDispatcher(testScheduler)
val handle = bind(worker, dispatcher)
Expand Down
Loading