Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tvm into the astro tarball #61

Merged
merged 7 commits into from
Jan 16, 2020
Merged

Include tvm into the astro tarball #61

merged 7 commits into from
Jan 16, 2020

Conversation

btromanova
Copy link
Contributor

@btromanova btromanova commented Jan 14, 2020

This addresses #58.

Sorry for the duplicate PR, the previous one (#59) was merged to the wrong branch.

Changes:

  • archive -> archives as the latest version of goreleaser only recognize the plural one
  • add tvm to the goreleaser builds (also add build id otherwise it defaults to project_name)
  • add note to readme to say that tvm is included
  • updated changelog

Tested it by pushing tag and running

docker run --rm --privileged -v $PWD:/go/src/github.com/uber/astro -v /var/run/docker.sock:/var/run/docker.sock -w /go/src/github.com/uber/astro -e GITHUB_TOKEN=<> goreleaser/goreleaser  release --rm-dist

I've seen that goreleaser was successful and the tarballs with both astro and tvm were published to github.

@btromanova btromanova requested a review from dansimau January 14, 2020 17:06
CHANGELOG.md Outdated
## 0.6.0 (January 15, 2020)

### Added
* Add `tmv` binary to astro release
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: tvm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@dansimau dansimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the typo but after that looks good.

@btromanova btromanova merged commit b80aa3d into master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants