Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(table): update table rfc based on feedback #632

Merged
merged 16 commits into from
Dec 18, 2018
Merged

Conversation

chasestarr
Copy link
Collaborator

Thanks @dswho for making the first pass on this rfc!

cc @CharlieMartell @ericsoco for feedback

@chasestarr chasestarr mentioned this pull request Dec 7, 2018
* `data: Array<Array<any>>` - Required
* Matrix data to be rendered within the table.
* `estimatedRowSize?: number = 40px`
* Passed to `react-virtualized`. Used to estimate table height.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CharlieMartell @ericsoco interested in your input on the react-virtualized specific api

another is useDynamicRowHeight on L184

@tajo
Copy link
Collaborator

tajo commented Dec 11, 2018

Nice write-up! Tables are really hard! Should we also think about the loading states (initial vs consequential) and empty data state?

@chasestarr
Copy link
Collaborator Author

regarding loading states, do you think a simple isLoading prop would be sufficient for enabling that ui?

@tajo
Copy link
Collaborator

tajo commented Dec 11, 2018

regarding loading states, do you think a simple isLoading prop would be sufficient for enabling that ui?

It should map to some visual state, right? Loading table can display some spinner or gray-out? Probably a good question for designers?

Similarly for the empty state, we probably want to display some message that spans the whole row (in this case it could be emptyStateComponent prop). Well and then you might need isEmpty prop since you don't want to show "No data" message before the initial loading is done.

Co-Authored-By: chasestarr <chasestarr@gmail.com>
@chasestarr chasestarr merged commit 052dd9b into master Dec 18, 2018
@baseui-probot-app-workflow baseui-probot-app-workflow bot deleted the docs/table-rfc branch December 18, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants