-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(table): update table rfc based on feedback #632
Conversation
* `data: Array<Array<any>>` - Required | ||
* Matrix data to be rendered within the table. | ||
* `estimatedRowSize?: number = 40px` | ||
* Passed to `react-virtualized`. Used to estimate table height. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CharlieMartell @ericsoco interested in your input on the react-virtualized specific api
another is useDynamicRowHeight
on L184
Nice write-up! Tables are really hard! Should we also think about the loading states (initial vs consequential) and empty data state? |
regarding loading states, do you think a simple |
It should map to some visual state, right? Loading table can display some spinner or gray-out? Probably a good question for designers? Similarly for the empty state, we probably want to display some message that spans the whole row (in this case it could be |
Co-Authored-By: chasestarr <chasestarr@gmail.com>
Thanks @dswho for making the first pass on this rfc!
cc @CharlieMartell @ericsoco for feedback