Change parentClosePolicy config flag #2567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samarabbas
approved these changes
Sep 18, 2019
longquanzheng
force-pushed
the
pcp-default
branch
from
91a6c80
to
4dda642
Compare
neil-xie
added a commit
that referenced
this pull request
Aug 23, 2022
neil-xie
added a commit
that referenced
this pull request
Aug 24, 2022
neil-xie
added a commit
that referenced
this pull request
Aug 29, 2022
neil-xie
added a commit
that referenced
this pull request
Sep 7, 2022
neil-xie
added a commit
that referenced
this pull request
Sep 8, 2022
neil-xie
added a commit
that referenced
this pull request
Sep 9, 2022
* Add support of update time for Cassandra, Mysql and Postgres (#2567) * Fix integration test * Fix one persistence test method * Fix mysql syntax error * Fix cassandra unit test * Add comment to explain unit of update timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As in uber-go/cadence-client#843
A better idea is to have enabledParentClosePolicy flag to control the default value. So that we can eventually get rid of the flag.