-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Deprecated code of Events V1 #2634
Conversation
073c3f0
to
12205bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The archival part looks good to me.
The archival history iterator test uses mock of historyManagerV1 interface and the test is quite complicated. Let me create a separate diff to change it to use historyV2 so your test can pass.
@wxing1292 I think they are a little bit different. The history iterator used by archiver needs the ability to get current state of the iterator and create a new iterator based on some previous states. I don't think the paging iterator supports that. The functionality is needed because archiver workflow needs to periodically record its current progress and resume from last saved state if worker restarts. There are some other issues like keeping current iterator state when error occurs, performing lookahead for nextPageToken etc. If you want, we can talk about it in more detail offline. |
If that is the case, then plz ignore the above comment. |
e18d5b6
to
d56217f
Compare
One year ago, I introduced History Events V2 with more functionality(forking branches) and performance(removing LWT). However we had to keep V1 running for backward compatibility. After one year, we have found that there is no more workflows running with V1. It's time to remove the V1 code and the logic of backward compatibility.
TODO: