Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQL implementation of UpdateExecution to support async transaction #4792

Merged
merged 2 commits into from
May 27, 2022

Conversation

Shaddoll
Copy link
Contributor

@Shaddoll Shaddoll commented Apr 6, 2022

What changed?
Update SQL implementation of UpdateExecution to support async transaction

Why?
To improve the latency of UpdateExecution for SQL implementation. There are multiple writes to different tables in the same transaction which we don't care about their order. Using async transaction can reduce network latency.

How did you test it?
run persistence test, run integration test, run bench test

Potential risks
It may break SQL implementation of UpdateExecution. The feature is controlled by a dynamic config. If we something goes wrong, we can turn off the feature by updating the dynamic config.

Release notes

Documentation Changes

@Shaddoll Shaddoll force-pushed the async-update branch 2 times, most recently from 4749383 to 364c29e Compare April 6, 2022 20:12
@coveralls
Copy link

coveralls commented Apr 6, 2022

Pull Request Test Coverage Report for Build 01810172-51b1-449c-92ee-a94e0b728ba2

  • 26 of 410 (6.34%) changed or added relevant lines in 11 files are covered.
  • 47 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.1%) to 56.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/dbVisibilityPersistenceTest.go 0 1 0.0%
common/persistence/persistence-tests/persistenceTestBase.go 2 10 20.0%
common/persistence/sql/sqlExecutionStore.go 2 11 18.18%
common/persistence/sql/sqlExecutionStoreUtil.go 0 366 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/sql/sqlExecutionStore.go 1 64.38%
common/task/weightedRoundRobinTaskScheduler.go 1 89.64%
common/persistence/executionManager.go 2 78.2%
common/persistence/statsComputer.go 2 96.43%
common/task/parallelTaskProcessor.go 2 92.75%
service/history/task/fetcher.go 4 91.28%
common/persistence/nosql/nosqlExecutionStore.go 9 61.26%
service/history/shard/context.go 9 65.84%
service/history/execution/context.go 17 70.29%
Totals Coverage Status
Change from base Build 0180ff88-4b5a-4504-a240-eae8ae5749f4: -0.1%
Covered Lines: 83977
Relevant Lines: 147650

💛 - Coveralls

@Shaddoll Shaddoll changed the title [WIP]Update SQL implementation of UpdateExecution to support async transaction Update SQL implementation of UpdateExecution to support async transaction May 26, 2022
Copy link
Contributor

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@Shaddoll Shaddoll merged commit 0582a58 into uber:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants