Improve failover coordinator error logging #4811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantas-sidlauskas
force-pushed
the
f_c_logger
branch
from
cba92a3
to
83792c6
Compare
Pull Request Test Coverage Report for Build 0ee5cd5b-3729-4938-b1ff-f4cae49db778
💛 - Coveralls |
| @@ -183,13 +184,12 @@ func CleanPendingActiveState( | |||
| // this call has to be made | |||
| metadata, err := domainManager.GetMetadata(context.Background()) | |||
| if err != nil { | |||
| return err | |||
| return fmt.Errorf("getting metadata: %w", err) | |||
There was a problem hiding this comment.
I don't have a great picture in my head for what might be listening to this error. Is there anything that might be doing an exact match on this which needs to be changed to use errors.As ?
There was a problem hiding this comment.
good point. but no, this error is just being used for logging purposes in coordinator.go:309 and failower_watcher.go:160
davidporter-id-au
approved these changes
May 4, 2022
mantas-sidlauskas
force-pushed
the
f_c_logger
branch
from
83792c6
to
8978d2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding err tags to log messages
Why?
This will help diagnose log messages as actual error now will be visible
How did you test it?
Potential risks
Release notes
Documentation Changes