Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fill domainID for backwards compatibility #4819

Merged

Conversation

vytautas-karpavicius
Copy link
Contributor

@vytautas-karpavicius vytautas-karpavicius commented May 6, 2022

What changed?
Added fallback to set domainID based on domainName for pending child executions when loading mutable state.

Why?
With #4601 newly introduced DomainID may not be set for older workflows.
Here we will fill its value based on previously used domain name.

Trying to store such mutable state to cassandra, it fails with error Invalid UUID ""

How did you test it?
Added unit test.

Potential risks

Release notes

Documentation Changes

@coveralls
Copy link

coveralls commented May 6, 2022

Pull Request Test Coverage Report for Build 3a3d09d0-4af8-43f1-a61b-212a94d181e0

  • 10 of 12 (83.33%) changed or added relevant lines in 1 file are covered.
  • 46 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.008%) to 56.963%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/history/execution/mutable_state_builder.go 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
common/membership/hashring.go 2 83.54%
service/matching/taskListManager.go 2 73.77%
service/history/task/fetcher.go 3 86.67%
common/persistence/nosql/nosqlExecutionStore.go 9 60.03%
common/persistence/nosql/nosqlplugin/cassandra/tasks.go 14 72.8%
common/persistence/nosql/nosqlTaskStore.go 16 58.37%
Totals Coverage Status
Change from base Build 8d87d80f-afd1-43e9-ba9d-8f82a47525d8: 0.008%
Covered Lines: 84000
Relevant Lines: 147464

💛 - Coveralls

@vytautas-karpavicius vytautas-karpavicius marked this pull request as ready for review May 9, 2022 14:46
@vytautas-karpavicius vytautas-karpavicius requested a review from a team May 9, 2022 14:46
@vytautas-karpavicius vytautas-karpavicius merged commit eede466 into uber:master May 10, 2022
@vytautas-karpavicius vytautas-karpavicius deleted the invalid-uuid-fix branch May 10, 2022 12:30
vytautas-karpavicius added a commit that referenced this pull request May 10, 2022
* Fill domainID for backwards compatibility

* Added unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants