Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomDomain and Operator as default indexed keys #4825

Merged
merged 3 commits into from
May 11, 2022

Conversation

mantas-sidlauskas
Copy link
Contributor

What changed?
Adding CustomDomain and Operator to default indexed keys

Why?
This will support batch workflow operations without manually adding those attributes later

How did you test it?
Running locally with ES/Kafka

Potential risks

Release notes

Documentation Changes

@mantas-sidlauskas mantas-sidlauskas changed the title Add CustomDomain and Operator to default indexed keys Add CustomDomain and Operator as default indexed keys May 10, 2022
@mantas-sidlauskas mantas-sidlauskas requested review from longquanzheng and a team May 10, 2022 12:14
@coveralls
Copy link

coveralls commented May 10, 2022

Pull Request Test Coverage Report for Build ba9f2ecf-8d2e-43b1-8145-2b167cb054f1

  • 24 of 33 (72.73%) changed or added relevant lines in 7 files are covered.
  • 117 unchanged lines in 17 files lost coverage.
  • Overall coverage decreased (-0.04%) to 56.917%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/dbVisibilityPersistenceTest.go 0 1 0.0%
tools/cli/util.go 0 1 0.0%
common/persistence/sql/sqlVisibilityStore.go 1 4 25.0%
common/persistence/nosql/nosqlVisibilityStore.go 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/nosql/nosqlVisibilityStore.go 1 50.42%
common/types/shared.go 1 26.66%
service/history/queue/timer_queue_processor_base.go 1 77.92%
client/history/client.go 2 38.58%
client/history/metricClient.go 2 45.3%
common/persistence/historyManager.go 2 66.67%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/handler.go 2 47.6%
service/history/task/transfer_active_task_executor.go 2 71.93%
service/matching/taskListManager.go 2 73.77%
Totals Coverage Status
Change from base Build c52c8cc8-c5f9-443a-b73e-dcbd31eb5d69: -0.04%
Covered Lines: 83931
Relevant Lines: 147461

💛 - Coveralls

@mantas-sidlauskas mantas-sidlauskas merged commit 45770c2 into uber:master May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants