Bugfix/correct failover issue target domain not active ii #4840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suspicion is that this is not actually a transient and retriable error, so this should be handled differently
Pull Request Test Coverage Report for Build 0180e356-69dd-44aa-9001-6ef4e0fce017
💛 - Coveralls |
vytautas-karpavicius
approved these changes
May 23, 2022
davidporter-id-au
deleted the
bugfix/correct-failover-issue-target-domain-not-active-ii
branch
davidporter-id-au
added a commit
that referenced
this pull request
May 24, 2022
* Removing target-domain-not-active special-case handling The suspicion is that this is not actually a transient and retriable error, so this should be handled differently * Fixing remaining non-retriable error * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the remaining check, introduced with
39bebb464which caused the domainNotFound error to be retried indefinitely under the incorrect assumption that the issue is transient.Why?
How did you test it?
Potential risks
Release notes
Documentation Changes