Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UpdateFromConfig function to schema tool library #4848

Merged
merged 2 commits into from
May 27, 2022

Conversation

Shaddoll
Copy link
Contributor

What changed?
Add UpdateFromConfig function to schema tool library

Why?
The existing function Update cannot be used by other package because it requires cli.Context as an input.

How did you test it?
existing test

Potential risks

Release notes

Documentation Changes

@Shaddoll Shaddoll enabled auto-merge (squash) May 27, 2022 00:54
@Shaddoll Shaddoll disabled auto-merge May 27, 2022 01:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 01810650-c971-47fc-9694-be677acb24ad

  • 0 of 5 (0.0%) changed or added relevant lines in 1 file are covered.
  • 21 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.03%) to 56.897%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tools/common/schema/handler.go 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
common/persistence/historyManager.go 2 66.67%
service/history/execution/mutable_state_builder.go 2 69.09%
service/history/task/fetcher.go 4 91.28%
service/history/task/transfer_standby_task_executor.go 4 88.46%
common/persistence/nosql/nosqlExecutionStore.go 9 61.26%
Totals Coverage Status
Change from base Build 0181052e-ffdc-4281-a23b-c80652ca199b: 0.03%
Covered Lines: 84006
Relevant Lines: 147646

💛 - Coveralls

@Shaddoll Shaddoll merged commit 12d8c54 into uber:master May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants