Add helper function to list all dynamic config keys used in production #4891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
force-pushed
the
dynamic-helper
branch
2 times, most recently
from
f84d560
to
2256472
Compare
| // ListAllProductionKeys returns all key used in production | ||
| func ListAllProductionKeys() []Key { | ||
| result := make([]Key, 0, len(IntKeys)+len(BoolKeys)+len(FloatKeys)+len(StringKeys)+len(DurationKeys)+len(MapKeys)) | ||
| for i := TestGetIntPropertyFilteredByTaskListInfoKey + 1; i < LastIntKey; i++ { |
There was a problem hiding this comment.
What do you think about also exposing methods for each of these as well which hides this implementation detail of the Last key and similar?
ListIntConfigKeys() etc?
There was a problem hiding this comment.
I don't find a use case for listing keys by type now. I can add that later if I find a use case
davidporter-id-au
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add helper function to list all dynamic config keys used in production
Why?
To provide a way to get all keys used in production excluding keys created for unit tests
How did you test it?
Potential risks
Release notes
Documentation Changes