Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separating tools dependencies from main dependencies #4895

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Separating tools dependencies from main dependencies #4895

merged 6 commits into from
Jul 6, 2022

Commits on Jul 6, 2022

  1. Separate tools.go from the main go.mod file 

    Adding gowrap in uber#4879 pulled in an additional *30MB* of dependencies, which is
pretty ridiculous.  It's happening because, while gowrap uses a tools-tagged `tools.go`,
it's in the same module as everything else, so its dependencies are pulled in too, because
Go has no way to tell that it's not needed by callers (it needs to consider ALL tags).

We're doing the same thing.  Granted, we're an application and not a library, but it still
seems kinda unnecessary.  And it forces upgrades we may not want to force (yet).

So this moves tools.go to a new package, sets up a new go.mod file just for it, and adds
a bit of automation to prevent it from drifting too far from the main module.
With this, `go mod tidy` in the top level does not consider tools-dependencies any more,
so we actually *remove* some, and do not add tons more for gowrap/etc in the future.

---

internal/tools is just because it needs to be in a separate package, and "tools" was taken.
plus nobody should ever import it, so it should be a clear "dependency dead-end".
    @Groxx
    Groxx committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    7211dc3 View commit details
    Browse the repository at this point in the history

  2. removed only explicit use of thrift too

    @Groxx
    Groxx committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    2be35aa View commit details
    Browse the repository at this point in the history

  3. yea, set -x is the obvious choice here

    @Groxx
    Groxx committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    2789b26 View commit details
    Browse the repository at this point in the history

  4. remove gowrap, not yet in use

    @Groxx
    Groxx committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    23d8bbd View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into tools 

    fixed conflict in makefile around @ -> $Q
    @Groxx
    Groxx committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    6994a97 View commit details
    Browse the repository at this point in the history

  6. fix dependency

    @Groxx
    Groxx committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    09f4c9a View commit details
    Browse the repository at this point in the history