Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing test. #4941

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Fixing test. #4941

merged 1 commit into from
Aug 19, 2022

Conversation

mindaugasbarcauskas
Copy link
Contributor

What changed?

Fixing test

Why?

Test was failing locally when running "make test"

How did you test it?

tested locally that test passes.

Potential risks

no risk.

Release notes

Documentation Changes

@coveralls
Copy link

Pull Request Test Coverage Report for Build 0182b5b3-56b1-40e7-a2d7-b1a3cbdb6e44

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 35 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.04%) to 57.719%

Files with Coverage Reduction New Missed Lines %
common/types/shared.go 1 41.63%
service/history/queue/transfer_queue_processor_base.go 1 78.05%
common/task/weightedRoundRobinTaskScheduler.go 2 89.64%
service/history/execution/mutable_state_builder.go 2 69.03%
service/history/task/transfer_active_task_executor.go 2 71.51%
service/matching/taskListManager.go 2 76.37%
common/persistence/nosql/nosqlplugin/cassandra/workflow.go 3 57.44%
common/types/mapper/thrift/shared.go 4 63.12%
service/history/task/transfer_standby_task_executor.go 4 86.68%
common/persistence/nosql/nosqlplugin/cassandra/workflowParsingUtils.go 14 83.16%
Totals Coverage Status
Change from base Build 0182b50c-0189-446a-a6f6-6e68a98e6385: 0.04%
Covered Lines: 84092
Relevant Lines: 145692

💛 - Coveralls

@mindaugasbarcauskas mindaugasbarcauskas merged commit 6ecd1e4 into master Aug 19, 2022
@mindaugasbarcauskas mindaugasbarcauskas deleted the CDNC-2738_fix_test branch August 19, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants