Separate liveness of task list into a dedicated entity #5105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
force-pushed
the
refactor-matching
branch
2 times, most recently
from
6276998
to
f95a87f
Compare
Shaddoll
changed the title
Shaddoll
changed the title
Shaddoll
force-pushed
the
refactor-matching
branch
2 times, most recently
from
62f02bd
to
3cf0e06
Compare
| @@ -230,6 +237,10 @@ func (c *taskListManagerImpl) handleErr(err error) error { | |||
| // be written to database and later asynchronously matched with a poller | |||
| func (c *taskListManagerImpl) AddTask(ctx context.Context, params addTaskParams) (bool, error) { | |||
| c.startWG.Wait() | |||
| if params.forwardedFrom == "" { | |||
| // request sent by history service | |||
| c.liveness.markAlive(time.Now()) | |||
There was a problem hiding this comment.
doesn't need to be here in this diff, but it'd be nice to pull this time-source from the taskListManagerImpl in future for testability
Shaddoll
force-pushed
the
refactor-matching
branch
from
3cf0e06
to
4e8f871
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
pick temporalio/temporal#1699
Why?
Improve readability
How did you test it?
New unit tests
Potential risks
Release notes
Documentation Changes