Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add remaining persistence stuff that goes to a shard #5142

Merged
merged 10 commits into from
Mar 13, 2023

Conversation

allenchen2244
Copy link
Contributor

What changed?
Add remaining persistence metrics that goes to a shard

Why?
Detect hotshards

How did you test it?
Unit tests/int test pass

Potential risks
I can't see anything that bad that could happen.

@coveralls
Copy link

coveralls commented Mar 9, 2023

Pull Request Test Coverage Report for Build 0186dd33-831e-4e5f-8e1f-14dbf15239f6

  • 45 of 68 (66.18%) changed or added relevant lines in 6 files are covered.
  • 61 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.07%) to 57.125%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/persistence/persistence-tests/persistenceTestBase.go 0 2 0.0%
common/persistence/persistenceMetricClients.go 40 61 65.57%
Files with Coverage Reduction New Missed Lines %
common/cache/lru.go 2 92.2%
common/task/fifoTaskScheduler.go 2 85.57%
common/task/parallelTaskProcessor.go 2 92.75%
service/history/execution/mutable_state_util.go 2 36.04%
common/persistence/statsComputer.go 3 94.64%
common/persistence/serialization/parser.go 4 63.91%
common/persistence/serialization/thrift_decoder.go 4 57.14%
common/persistence/sql/workflowStateMaps.go 12 83.62%
service/history/execution/mutable_state_task_refresher.go 14 62.03%
common/persistence/serialization/getters.go 16 59.92%
Totals Coverage Status
Change from base Build 0186dd16-64e5-41ea-83eb-da3afa02f945: 0.07%
Covered Lines: 85344
Relevant Lines: 149399

💛 - Coveralls

@allenchen2244 allenchen2244 enabled auto-merge (squash) March 9, 2023 21:21
Copy link
Contributor

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of the sampleRate for logging. Hopefully dynamicConfig doesn't mind being hit that hard

@allenchen2244 allenchen2244 merged commit 61c64c3 into master Mar 13, 2023
@allenchen2244 allenchen2244 deleted the shard-persistence-metrics branch March 13, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants